feat(megatron): migrate profiler args in core workflow#573
Merged
wenxie-amd merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
HuangWei-95
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
wenxie-amd
approved these changes
Mar 2, 2026
added 2 commits
March 3, 2026 09:47
### Changes: - Introduced a new file `torch_profiler_patchers.py` that patches `torch.profiler.profile` to integrate Primus-specific options during training. - Implemented logic to check if the profiler is called from `megatron.training.train` and create a profiler with appropriate settings. - Added error handling and logging for better debugging. ### Reason for changes: This patch enhances the profiling capabilities of Megatron by allowing the use of Primus options, improving performance monitoring during training sessions.
- Improved error handling and logging in `torch_profiler_patchers.py` to provide clearer debugging information when issues arise during profiling. - Refined logic to ensure compatibility with various training scenarios in Megatron. These enhancements aim to facilitate better debugging and monitoring of profiling issues, ultimately improving the user experience when utilizing Primus options in Megatron's training process.
HuangWei-95
force-pushed
the
feat/megatron/torch_profiler
branch
from
93675d7 to
2a37626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(megatron): migrate profiler args in core workflow